Defect #7

KOW_Sec.Criterias_Util.Expression_Access memory leak

Added by Marcelo Coraça de Freitas over 2 years ago. Updated about 1 year ago.

Status:Closed Start date:12/08/2010
Priority:Alto Due date:12/09/2010
Assignee:Marcelo Coraça de Freitas % Done:

0%

Category:- Spent time: 4.00 hours
Target version:- Estimated time:7.00 hours

Description

The Expression_Access type is being allocated but not deallocated anywhere.

It's a memory leak bug that affects most systems but the problem root is localized at KOW_Sec only.


Related issues

follows KOW Sec - Enhancement #142: Remove OOP from the User Type Closed 11/19/2010 12/07/2010

History

Updated by Marcelo Coraça de Freitas almost 2 years ago

  • Priority changed from Urgente to Alto

even though any memory leak is reason for us to be worried this isn't really a big issue as only small amount of memory is being trashed so far.. but this will become urgent when we get >1000 users in our systems.

Updated by Marcelo Coraça de Freitas about 1 year ago

  • Due date changed from 11/18/2010 to 12/09/2010
  • Status changed from New to Accepted
  • Start date changed from 11/18/2010 to 12/08/2010
  • Estimated time set to 7.00

this will require a major redesign of the entire parsing module

the algorithim is not exactly clear to me right now and the package names are not according to the best standards... but that's nothing that can't be at least fixed. :)

Updated by Marcelo Coraça de Freitas about 1 year ago

I am renaming the entire package and all the types so it makes more sence.

Also, instead of using generic packages and having to call the exact same parser structure every single time I decided to switch to an OOP approach.

There is a new abstract type called KOW_Sec.Logic_Criterias.Logic_Criteria_Type that implements three new methods (being one abstract and the other two null).

Those methods are the one that the criteria implementor must extend in order to make things work.

Also, there is a generic factory for criterias extending this one. :)

Updated by Marcelo Coraça de Freitas about 1 year ago

the refactoring is complete.

my next step will be fixing up the memory leak (I'm going to use the same approach I used at the kow_lib.json package)

Updated by Marcelo Coraça de Freitas about 1 year ago

I forgot this one today and I worked in KOW_Sec.Data cache which hasn't even been predicted for now! O.o

Updated by Marcelo Coraça de Freitas about 1 year ago

  • Status changed from Accepted to Fixed

Finally fixed with something close to what I first intended... but I also added some generic package magic in the mix :)

Updated by Marcelo Coraça de Freitas about 1 year ago

  • Status changed from Fixed to Closed

Also available in: Atom PDF